🎨 [Frontend] Rebranding: S4L lite -> Sim4Life.lite #6524
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eofli
approved these changes
Oct 14, 2024
pcrespov
reviewed
Oct 14, 2024
services/static-webserver/client/source/class/osparc/product/quickStart/s4llite/Dashboard.js
Show resolved
Hide resolved
services/static-webserver/client/source/class/osparc/product/quickStart/s4llite/Dashboard.js
Show resolved
Hide resolved
|
@pcrespov Regarding the string replacements, in the Quick Start, yes, you are right, what you suggest is better, but I anyway plan to move all this content to its own product/vendor repository, so that POs can update it without changing the frontend. That's why in this case I went for a quick string replacement. |
matusdrobuliak66
approved these changes
Oct 14, 2024
ignapas
approved these changes
Oct 15, 2024
|
18 tasks
This was referenced Oct 29, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Related issue/s
How to test
Dev-ops checklist